CWE-696: Incorrect Behavior Order

Causes

• The following code attempts to validate a given input path by checking it against an allowlist and then return the canonical path. In this specific case, the path is considered valid if it starts with the string "/safe_dir/". The problem with the above code is that the validation step occurs before canonicalization occurs. An attacker could provide an input path of "/safe_dir/../" that would pass the validation step. However, the canonicalization process sees the double dot as a traversal to the parent directory and hence when canonicized the path would become just "/".,To avoid this problem, validation should occur after canonicalization takes place. In this case canonicalization occurs during the initialization of the File object. The code below fixes the issue.
• This function prints the contents of a specified file requested by a user. This code first reads a specified file into memory, then prints the file if the user is authorized to see its contents. The read of the file into memory may be resource intensive and is unnecessary if the user is not allowed to see the file anyway.
• Assume that the module foo_bar implements a protected register. The register content is the asset. Only transactions made by user id (indicated by signal usr_id) 0x4 are allowed to modify the register contents. The signal grant_access is used to provide access. This code uses Verilog blocking assignments for data_out and grant_access. Therefore, these assignments happen sequentially (i.e., data_out is updated to new value first, and grant_access is updated the next cycle) and not in parallel. Therefore, the asset data_out is allowed to be modified even before the access control check is complete and grant_access signal is set. Since grant_access does not have a reset value, it will be meta-stable and will randomly go to either 0 or 1.,Flipping the order of the assignment of data_out and grant_access should solve the problem. The correct snippet of code is shown below.

Remediation

• Use safe APIs
• Centralize the control
• Add regression tests
• Review logs and telemetry for attempted abuse

Detection

• Code review
• SAST
• DAST
• Focused regression tests

Related CWEs

• CWE-1190: DMA Device Enabled Too Early in Boot Phase
• CWE-1193: Power-On of Untrusted Execution Core Before Enabling Fabric Access Control
• CWE-1279: Cryptographic Operations are run Before Supporting Units are Ready
• CWE-1280: Access Control Check Implemented After Asset is Accessed
• CWE-179: Incorrect Behavior Order: Early Validation
• CWE-408: Incorrect Behavior Order: Early Amplification
• CWE-551: Incorrect Behavior Order: Authorization Before Parsing and Canonicalization
• CWE-691: Insufficient Control Flow Management

Related CVEs

Related CVE mappings appear after CVE records are cross-indexed.

ATT&CK Relevance

ATT&CK relevance is shown only when reviewed or responsibly inferred.